Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bootable-usb): add Fedora #699

Closed
wants to merge 14 commits into from
Closed

feat(bootable-usb): add Fedora #699

wants to merge 14 commits into from

Conversation

lennartpj
Copy link
Contributor

@lennartpj lennartpj commented Sep 29, 2024 •
edited
Loading

Type of Change

  • New feature
  • Bug fix

Description

This pull request adds functionality to download the latest Fedora 40 Workstation ISO in the "create-bootable-usb.sh". It also fixes a bug in the confirmation prompt, allowing users to proceed by entering 'y', 'yes', and case-insensitive variants.

Testing

I have tested the changes by executing cargo run and going through the steps.
After the Script executed I was able to boot from the USB stick into the Fedora Setup.

The confirmation prompt now accepts 'y', 'yes', and case-insensitive variants.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@lennartpj lennartpj changed the title Adding Fedora ISO download. Adding Fedora ISO download and fixing a bug in the confirmation prompt. Sep 29, 2024
adamperkowski
adamperkowski requested changes Sep 29, 2024
View reviewed changes
core/tabs/utils/create-bootable-usb.sh Outdated Show resolved Hide resolved
core/tabs/utils/create-bootable-usb.sh Outdated Show resolved Hide resolved
@adamperkowski
Copy link
Collaborator

The confirmation prompt accepts 'y', 'yes', and case-insensitive variants. The output is displayed as expected, and the script functions as intended.

Please rewrite the code and this PRs description without using AI/LLMs.

@adamperkowski
Copy link
Collaborator

Add this to docs/userguide.md

@lj3954
Copy link
Contributor

lj3954 commented Sep 30, 2024

Hardcoding releases induces a major maintenance burden. Please use APIs available to you: https://www.fedoraproject.org/releases.json

@lennartpj
Copy link
Contributor Author

Hardcoding releases induces a major maintenance burden. Please use APIs available to you: https://www.fedoraproject.org/releases.json

Thank you for the advice! I have changed my part accordingly

@adamperkowski
Copy link
Collaborator

@lennartpj Please click resolve conversation for all resolved threads here.

adamperkowski
adamperkowski approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lennartpj
Copy link
Contributor Author

@adamperkowski
Thank you very much! I still have a lot to learn :)

@ChrisTitusTech ChrisTitusTech mentioned this pull request Sep 30, 2024
Closed
4 tasks
adamperkowski
adamperkowski requested changes Oct 9, 2024
View reviewed changes
docs/userguide.md Outdated Show resolved Hide resolved
@lj3954 lj3954 mentioned this pull request Oct 15, 2024
Merged
5 tasks
adamperkowski
adamperkowski approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

core/tabs/utils/create-bootable-usb.sh Outdated Show resolved Hide resolved
@adamperkowski adamperkowski added the enhancement New feature or request label Oct 27, 2024
@lennartpj
Copy link
Contributor Author

@adamperkowski I have change the version from 40 to 41.
I have also tested the change and made a fresh install of fedora 41 using this method.

@adamperkowski adamperkowski changed the title Adding Fedora ISO download and fixing a bug in the confirmation prompt. feat(bootable-usb): add Fedora Oct 30, 2024
adamperkowski
adamperkowski approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@adamperkowski adamperkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamperkowski I have change the version from 40 to 41. I have also tested the change and made a fresh install of fedora 41 using this method.

Thanks. Good to merge.

@jeevithakannan2
Copy link
Contributor

#828 was merged this can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lj3954 lj3954 lj3954 left review comments

@adamperkowski adamperkowski adamperkowski approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lennartpj @adamperkowski @lj3954 @jeevithakannan2